legacy support fixes

rudderlabs · Mar 22, 2021 · b93cb60 · b93cb60
1 parent 815d29a
commit b93cb60
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/integrations/Clevertap/browser.js b/integrations/Clevertap/browser.js
@@ -110,8 +110,8 @@ class Clevertap {
     } catch (err) {
       logger.debug(`Error occured at extractCustomFields ${err}`);
     }
-    Object.values(payload).map((vals) => {
-      if (isObject(vals)) {
+    Object.keys(payload).map((key) => {
+      if (isObject(payload[key])) {
         logger.debug("cannot process, unsupported traits");
         return;
       }
@@ -144,8 +144,8 @@ class Clevertap {
         }
         window.clevertap.event.push("Charged", ecomProperties);
       } else {
-        Object.values(properties).map((vals) => {
-          if (isObject(vals) || isArray(vals)) {
+        Object.keys(properties).map((key) => {
+          if (isObject(properties[key]) || isArray(properties[key])) {
             logger.debug("cannot process, unsupported event");
             return;
           }
@@ -171,8 +171,8 @@ class Clevertap {
       eventName = "WebPage Viewed";
     }
     if (properties) {
-      Object.values(properties).map((vals) => {
-        if (isObject(vals) || isArray(vals)) {
+      Object.keys(properties).map((key) => {
+        if (isObject(properties[key]) || isArray(properties[key])) {
           logger.debug("cannot process, unsupported event");
           return;
         }

diff --git a/utils/utils.js b/utils/utils.js
@@ -541,7 +541,9 @@ function extractCustomFields(message, destination, keys, exclusionFields) {
     if (messageContext) {
       const objKeys = [];
       Object.keys(messageContext).map((k) => {
-        if (!exclusionFields.includes(k)) objKeys.push(k);
+        if (exclusionFields.indexOf(k) < 0) {
+          objKeys.push(k);
+        }
       });
       objKeys.map((k) => {
         if (!(typeof messageContext[k] === "undefined")) {
@@ -553,9 +555,9 @@ function extractCustomFields(message, destination, keys, exclusionFields) {
   return destination;
 }
 /**
- * 
- * @param {*} message 
- * 
+ *
+ * @param {*} message
+ *
  * Use get-value to retrieve defined trais from message traits
  */
 function getDefinedTraits(message) {
@@ -640,5 +642,5 @@ export {
   extractCustomFields,
   getDefinedTraits,
   isObject,
-  isArray
+  isArray,
 };