feature(ConvertFlow): updating properties

rudderlabs · Aug 16, 2022 · 70e2abc · 70e2abc
1 parent b74c956
commit 70e2abc
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 10 deletions.
diff --git a/integrations/ConvertFlow/browser.js b/integrations/ConvertFlow/browser.js
@@ -19,13 +19,13 @@ class ConvertFlow {
       "convertflow-integration",
       `https://js.convertflow.co/production/websites/${this.websiteId}.js`
     );
-    if (this.toggleToSendData) {
-      this.trigger();
-    }
   }
 
   isLoaded() {
     logger.debug("===In isLoaded convertflow===");
+    if (this.toggleToSendData) {
+      this.trigger();
+    }
     return !!window.convertflow && typeof window.convertflow === "object";
   }
 

diff --git a/integrations/ConvertFlow/utils.js b/integrations/ConvertFlow/utils.js
@@ -1,4 +1,7 @@
-import { getHashFromArray } from "../utils/commonUtils";
+import {
+  getHashFromArray,
+  isDefinedAndNotNullAndNotEmpty,
+} from "../utils/commonUtils";
 
 // default mapping for the events
 const standardEventsListMapping = {
@@ -25,12 +28,23 @@ const makeACall = (standardEventsMap, eventName, data) => {
       updatedEvent = event;
     }
   });
-  if (data && data.cta) {
-    window.rudderanalytics.track(updatedEvent, {
-      name: data.cta.name,
-      cta_type: data.cta.cta_type,
-      id: data.cta.id,
-    });
+  const properties = {};
+  if (data) {
+    if (data.cta) {
+      const { cta } = data;
+      properties.cta_name = cta.name;
+      properties.cta_type = cta.cta_type;
+      properties.cta_id = cta.id;
+    }
+    if (data.variant) {
+      properties.cta_variant = data.variant.variation;
+    }
+    if (data.step) {
+      properties.cta_step = data.step.position;
+    }
+  }
+  if (isDefinedAndNotNullAndNotEmpty(properties)) {
+    window.rudderanalytics.track(updatedEvent, properties);
   } else {
     window.rudderanalytics.track(updatedEvent);
   }