fix tests

rudderlabs · Jan 12, 2021 · 6635513 · 6635513
1 parent 9dadc82
commit 6635513
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/integrations/GA/browser.js b/integrations/GA/browser.js
@@ -41,7 +41,7 @@ export default class GA {
     ];
   }
 
-  initializeAndloadScript() {
+  initializeGlobalObject() {
     window.GoogleAnalyticsObject = "ga";
     window.ga =
       window.ga ||
@@ -50,6 +50,9 @@ export default class GA {
         window.ga.q.push(arguments);
       };
     window.ga.l = new Date().getTime();
+  }
+
+  loadScript() {
     ScriptLoader(
       "google-analytics",
       "https://www.google-analytics.com/analytics.js"
@@ -84,7 +87,8 @@ export default class GA {
     });
 
     if (this.analytics.loadIntegration) {
-      this.initializeAndloadScript();
+      this.initializeGlobalObject();
+      this.loadScript();
     }
 
     // create ga with these properties. if the properties are empty it will take default values.

diff --git a/integrations/GA/index.test.js b/integrations/GA/index.test.js
@@ -7,7 +7,7 @@ afterAll(() => {
   jest.restoreAllMocks();
 });
 
-GA.prototype.initializeAndloadScript = jest.fn();
+GA.prototype.loadScript = jest.fn();
 
 describe("GA init tests", () => {
   let googleAnalytics;