initial changes for testing

rudderlabs · Sep 30, 2019 · 42a53e7 · 42a53e7
1 parent 478d0d8
commit 42a53e7
Show file tree

Hide file tree

Showing 4 changed files with 2,540 additions and 6 deletions.
diff --git a/rudder-client-javascript/integration/HubSpot.js b/rudder-client-javascript/integration/HubSpot.js
@@ -14,11 +14,13 @@ var HubspotAnalyticsManager = function HubspotAnalyticsManager(hubId) {
         }, 3000)
 
       }); */
-      $.ajax({
+      /* $.ajax({
         async: false,
         url: "https://js.hs-scripts.com/"+this.hubId+".js",
         dataType: "script"
-      });
+      }); */
+      var hubspotJs = "https://js.hs-scripts.com/"+this.hubId+".js"
+      require(hubspotJs)
       console.log("===in constructor===");
     }
     return {
@@ -50,8 +52,8 @@ var HubspotAnalyticsManager = function HubspotAnalyticsManager(hubId) {
       var traits = rudderElement.rl_message.rl_context.rl_traits
       var traitsValue = {}
 
-      for(var k in traits){
-          if(traits[k]){
+      for(var k in traits){ 
+          if(!!Object.getOwnPropertyDescriptor(traits, k) && traits[k]){
             var hubspotkey = k.startsWith("rl_") ? k.substring(3, k.length) : k;
             traitsValue[hubspotkey] = traits[k]
           }
@@ -61,7 +63,7 @@ var HubspotAnalyticsManager = function HubspotAnalyticsManager(hubId) {
         //traitsValue.delete(address)
         delete traitsValue['address']
         for(k in address){
-          if(address[k]){
+          if(!!Object.getOwnPropertyDescriptor(address, k) && address[k]){
             hubspotkey = k.startsWith("rl_") ? k.substring(3, k.length) : k;
             hubspotkey = (hubspotkey == 'street') ? 'address' : hubspotkey
             traitsValue[hubspotkey] = address[k]
@@ -70,7 +72,7 @@ var HubspotAnalyticsManager = function HubspotAnalyticsManager(hubId) {
       }
       var userProperties = rudderElement.rl_message.rl_context.rl_user_properties
       for(k in userProperties){
-        if(userProperties[k]){
+        if(!!Object.getOwnPropertyDescriptor(userProperties, k) && userProperties[k]){
           hubspotkey = k.startsWith("rl_") ? k.substring(3, k.length) : k;
           traitsValue[hubspotkey] = userProperties[k]
         }

diff --git a/rudder-client-javascript/package.json b/rudder-client-javascript/package.json
@@ -4,6 +4,7 @@
   "description": "",
   "main": ".eslintrc.js",
   "scripts": {
+    "start": "node RudderClient.js",
     "test": "echo \"Error: no test specified\" && exit 1"
   },
   "author": "",

diff --git a/rudder-client-javascript/test/HubSpotTestPage.html b/rudder-client-javascript/test/HubSpotTestPage.html
@@ -0,0 +1,64 @@
+<html>
+
+<head>
+    <script src="http://ajax.googleapis.com/ajax/libs/jquery/1.7.1/jquery.min.js" type="text/javascript"></script>
+    <script src="RudderClientBundle.js"></script>
+
+</head>
+
+<body>
+    <h1>Page Loaded</h1>
+
+    <script type="text/javascript">
+        //identify("[email protected]","testname4","111222", "6405167");
+        //alert('about to execute HS code');
+        //alert('HS code executed');  
+
+        var handler = setInterval(function () {
+            console.log(window.ECommerceParamNames)
+            var loaded = !! window.RudderClient
+            console.log("loaded==", loaded)
+            if(!loaded) {
+                return
+            }
+            var rudderClient = window.RudderClient
+
+            var client = rudderClient.getInstance("1QbNPCBQp2RFWolFj2ZhXi2ER6a", RudderConfig.getDefaultConfig().setFlushQueueSize(1));
+            client.identify((new RudderTraits()).
+                setName("Donald Duck").
+                setEmail("[email protected]").
+                setId(generateUUID()));
+            clearInterval(handler)
+        }, 3000)
+
+        /* client.page(new RudderElementBuilder().
+         setProperty(new PagePropertyBuilder().
+            setTitle("Blog Page").
+            setUrl("https://rudderlabs.com").
+            setPath("/blogstest").
+            setReferrer("https://www.rudderlabs.com").
+            build().
+            getPropertyMap()).
+            build()); */
+        /* client.track(new RudderElementBuilder().
+        setEvent("Order Updated").
+        setProperty(new OrderRefundedEvent().
+        setOrder(new ECommerceOrder().
+        setOrderId("Dummy Order 9").
+        setAffiliation("Dummy Affiliation 4").
+        setTotal(30).
+        setRevenue(25.00).
+        setShipping(3).
+        setTax(2).
+        setDiscount(2.5).
+        setCoupon("hasbros").
+        setCurrency("USD").
+        addProduct(new ECommerceProduct().setName("Dummy Product 7")).
+        addProduct(new ECommerceProduct().setName("Dummy Product 8").setSku("Dummy SKU 4"))).
+        build().getPropertyMap()).
+        build()); */
+    </script>
+    <!--script type="text/javascript" id="hs-script-loader" async defer src="//js.hs-scripts.com/6405167.js" ></script> -->
+</body>
+
+</html>