Made Minor Fixes and Added Appcues to integration_cname and client_se…

…rver_name.js
rudderlabs · Dec 24, 2020 · 14f43be · 14f43be
1 parent 69f0152
commit 14f43be
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 7 deletions.
diff --git a/integrations/Appcues/browser.js b/integrations/Appcues/browser.js
@@ -24,7 +24,8 @@ class Appcues {
 
   isReady() {
     logger.debug("in appcues isReady");
-    // if (this.sendToAllDestinations) {
+    // This block of code enables us to send Appcues Flow events to all the other destinations connected to the same source (we might use it in future)
+    // if (this.sendToAllDestinations && window.Appcues) {
     //   window.Appcues.on("all", function(eventName, event) {
     //     window.rudderanalytics.track(eventName, event, {
     //       integrations: {
@@ -46,6 +47,8 @@ class Appcues {
     } = rudderElement.message;
     if (userId) {
       window.Appcues.identify(userId, traits);
+    } else {
+      logger.error("user id is empty");
     }
   }
 
@@ -56,21 +59,23 @@ class Appcues {
     } = rudderElement.message;
     if (eventName) {
       window.Appcues.track(eventName, properties);
+    } else {
+      logger.error("event name is empty");
     }
   }
 
   page(rudderElement) {
     const {
       properties,
-      name,
-      category
+      name
     } = rudderElement.message;
     window.Appcues.page(name, properties);
   }
-
-  reset() {
-    window.Appcues.reset();
-  }
+
+  // To be uncommented after adding Reset feature to our SDK
+  // reset() {
+  //   window.Appcues.reset();
+  // }
 
 }
 

diff --git a/integrations/client_server_name.js b/integrations/client_server_name.js
@@ -25,6 +25,7 @@ const clientToServerNames = {
   AM: "Amplitude",
   PENDO: "Pendo",
   LYTICS: "Lytics",
+  APPCUES: "Appcues",
 };
 
 export { clientToServerNames };
diff --git a/integrations/integration_cname.js b/integrations/integration_cname.js
@@ -54,6 +54,8 @@ const commonNames = {
   PENDO: "PENDO",
   Lytics: "Lytics",
   LYTICS: "Lytics",
+  Appcues: "APPCUES",
+  APPCUES: "APPCUES",
 };
 
 export { commonNames };