Read userId from cookie, only set on GA if user non anonymous

rudderlabs · May 4, 2020 · 101367f · 101367f
1 parent 039242e
commit 101367f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/dist/rudder-analytics.min.js b/dist/rudder-analytics.min.js
diff --git a/integrations/GA/browser.js b/integrations/GA/browser.js
@@ -1,4 +1,6 @@
 import logger from "../../utils/logUtil";
+import { Cookie } from "../../utils/storage/cookie";
+
 class GA {
   constructor(config) {
     this.trackingID = config.trackingID;
@@ -33,20 +35,21 @@ class GA {
     ga("create", this.trackingID, "auto", "rudder_ga", {
       allowLinker: this.allowLinker,
     });
+
+    var userId = Cookie.get('rl_user_id');
+    if (userId && userId !== '') {
+      ga("rudder_ga.set", "userId", userId);
+    }
     //ga("send", "pageview");
 
     logger.debug("===in init GA===");
   }
 
-  setUserId(rudderElement) {
+  identify(rudderElement) {
     var userId = rudderElement.message.userId !== ''
       ? rudderElement.message.userId
       : rudderElement.message.anonymousId
     ga("rudder_ga.set", "userId", userId);
-  }
-
-  identify(rudderElement) {
-    this.setUserId(rudderElement);
     logger.debug("in GoogleAnalyticsManager identify");
   }
 
@@ -74,7 +77,6 @@ class GA {
       eventLabel: eventLabel,
       eventValue: eventValue
     };
-    this.setUserId(rudderElement);
     ga("rudder_ga.send", "event", payLoad);
     logger.debug("in GoogleAnalyticsManager track");
   }
@@ -103,7 +105,6 @@ class GA {
     if (location) {
       ga("rudder_ga.set", "location", location);
     }
-    this.setUserId(rudderElement);
     ga("rudder_ga.send", "pageview");
 
   }