-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: web config options update to the latest #179
Merged
MoumitaM
merged 6 commits into
develop
from
feature/sdk-2192-research-the-missing-parts-of-the-config-parameters
Sep 17, 2024
Merged
feat!: web config options update to the latest #179
MoumitaM
merged 6 commits into
develop
from
feature/sdk-2192-research-the-missing-parts-of-the-config-parameters
Sep 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: A few existing web config options has been removed and replaced with new structure. Latest web config options has been added
1abhishekpandey
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
saikumarrs
requested changes
Sep 16, 2024
packages/plugins/rudder_plugin_interface/lib/src/constants.dart
Outdated
Show resolved
Hide resolved
packages/plugins/rudder_plugin_interface/lib/src/models/rudder_config.dart
Outdated
Show resolved
Hide resolved
packages/plugins/rudder_plugin_interface/lib/src/models/rudder_config.dart
Outdated
Show resolved
Hide resolved
packages/plugins/rudder_plugin_interface/lib/src/models/web_config_interfaces/load_opts.dart
Outdated
Show resolved
Hide resolved
packages/plugins/rudder_plugin_interface/test/src/models/rudder_config_test.dart
Outdated
Show resolved
Hide resolved
packages/plugins/rudder_plugin_interface/lib/src/models/web_config_interfaces/storage_opts.dart
Outdated
Show resolved
Hide resolved
|
saikumarrs
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
These parameters are all part of some load options. The same structure as JS is used to intake these parameters.
For example:
queueOptions = { maxRetryDelay: 360000, minRetryDelay: 1000, backoffFactor: 2, maxAttempts: 10, maxItems: 100 }
Type of change
Checklists
Development
Code review