Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: web config options update to the latest #179

Conversation

MoumitaM
Copy link
Contributor

@MoumitaM MoumitaM commented Sep 13, 2024

Description of the change

Breaking Changes: Web config options have been updated as per JS SDK v3 load options.

  • The mentioned web config parameters are removed:
  1. maxRetryDelay
  2. minRetryDelay
  3. backoffFactor
  4. maxAttempts
  5. maxItems
  6. maxBeaconItems
  7. beaconFlushQueueInterval
  8. autoSessionTracking
  9. sessionTimeoutInMillis
  10. cookieConsentManagers

These parameters are all part of some load options. The same structure as JS is used to intake these parameters.

For example:

  1. The first 5 parameters are part of queueOptions:
    queueOptions = { maxRetryDelay: 360000, minRetryDelay: 1000, backoffFactor: 2, maxAttempts: 10, maxItems: 100 }
  2. maxBeaconItems, beaconFlushQueueInterval are part of beaconQueueOptions load option.
  3. autoSessionTracking, sessionTimeoutInMillis are part of sessions load option.
  4. cookieConsentManagers have been modified to consentManagement.
  • New web config parameters are added

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

BREAKING CHANGE: A few existing web config options has been removed and replaced with new structure. Latest web config options has been added
@MoumitaM MoumitaM requested a review from a team as a code owner September 13, 2024 04:36
@MoumitaM MoumitaM marked this pull request as draft September 13, 2024 04:37
@MoumitaM MoumitaM changed the title feat!: web config options update to the latest feat: web config options update to the latest Sep 13, 2024
@MoumitaM MoumitaM changed the title feat: web config options update to the latest feat!: web config options update to the latest Sep 13, 2024
@MoumitaM MoumitaM requested a review from saikumarrs September 13, 2024 05:17
@saikumarrs saikumarrs changed the title feat!: web config options update to the latest feat!(sdk): web config options update to the latest Sep 13, 2024
@saikumarrs saikumarrs changed the title feat!(sdk): web config options update to the latest feat!: web config options update to the latest Sep 13, 2024
@MoumitaM MoumitaM self-assigned this Sep 13, 2024
@MoumitaM MoumitaM marked this pull request as ready for review September 13, 2024 05:25
Copy link
Contributor

@1abhishekpandey 1abhishekpandey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link

@MoumitaM MoumitaM merged commit ee8c1eb into develop Sep 17, 2024
8 of 9 checks passed
@1abhishekpandey 1abhishekpandey deleted the feature/sdk-2192-research-the-missing-parts-of-the-config-parameters branch October 23, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants