Dup as_json options if frozen for Rails 8 compatibility #625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 8.0 introduced a change which freezes the
options
hash in ActiveSupport's.as_json
method.quickbooks-ruby overrides this method to add some ROXML exclusions, and this now breaks after updating to Rails 8.
The change also broke some other packages which do similar things.
This PR adds a check to
dup
the hash if it's frozen so it can be modified which avoids the issue.