Fintechqb 1967 enable service level logging #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andymond
commented
May 31, 2023
andymond
commented
- Update log check to be configurable by whatever class includes the logging module, preserving default functionality.
- Support the case where we would like to have some services log without enabling logging through our application instance.
In a recent update to the QBO API, if a company that uses automated sales tax has an invoice that has no tax amount, we need to specify TotalTaxSpecified = false. Not passing this results in an error from QBO indicating that sales tax was miscalculated.
…ction-tax-detail Add total tax specified to transaction tax detail
… per request and once per response if enabled
…ption Add condense_logs to quickbooks config & update logs to only log once…
Merge ruckus latest into codefied
…gging utility to allow per-service-instance logging capability
…t memoizing to handle @log explicitly being set to false for an instance
|
Thank you! |
ruckus
pushed a commit
that referenced
this pull request
Jul 13, 2023
* Add total_tax_specified xml_accessor to TransactionTaxDetail In a recent update to the QBO API, if a company that uses automated sales tax has an invoice that has no tax amount, we need to specify TotalTaxSpecified = false. Not passing this results in an error from QBO indicating that sales tax was miscalculated. * Accidentally commited a binding.pry * Add condense_logs to quickbooks config & update logs to only log once per request and once per response if enabled * Update variable names & move condense_logs? checks to logging util * Update Quickbooks.log to log without condition & move condition to logging utility to allow per-service-instance logging capability * Update README to include instance configurability demo * Update log settings check to check for ivar definition instead of just memoizing to handle @log explicitly being set to false for an instance --------- Co-authored-by: Daniel Ho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.