Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit dependency on Faraday < 2.0 #571

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

Zajn
Copy link
Contributor

@Zajn Zajn commented Mar 15, 2022

Faraday made some fairly significant changes in the 2.0
update. quickbooks-ruby currently uses a Faraday middlware, which
was deprecated in the 2.0 update. This adds an explicit
dependency on Faraday < 2.0 rather than using whatever Faraday version
the oauth-2 gem installs.

Fixes #570

Faraday made some fairly significant changes in the 2.0
update. `quickbooks-ruby` currently uses a Faraday middlware, which
[was deprecated][1] in the 2.0 update. This adds an explicit
dependency on Faraday < 2.0 rather than using whatever Faraday version
the oauth-2 gem installs.

[1]:https://github.com/lostisland/faraday/blob/main/UPGRADING.md#faraday-middleware-deprecation
@ruckus ruckus merged commit 0641814 into ruckus:master Mar 16, 2022
@ruckus
Copy link
Owner

ruckus commented Mar 16, 2022

Thanks @Zajn - much appreciated.

@diogogallo
Copy link

Hello @Zajn / @ruckus any plans to upgrade to Faraday > 2.0?

@TomA-R
Copy link

TomA-R commented Jun 1, 2022

This would be really good, otherwise we're stuck on Faraday < 2. Is this on the roadmap @ruckus ?

@ruckus
Copy link
Owner

ruckus commented Jun 1, 2022

@TomA-R I think/hope/pray that supporting of Faraday > 2 is as simple as:

  • removing the current gzip middleware as a whole. Probably not a big deal at the end of the day. Or, find a suitable replacement. But probably simpler to just yank it.
  • switch to the Faraday > 2 model for HTTP Basic auth currently used
    here:

https://github.com/ruckus/quickbooks-ruby/blob/master/lib/quickbooks/service/access_token.rb#L25

in favor of the new helpers discussed here:

https://lostisland.github.io/faraday/middleware/authentication

The reality is that at this juncture I don't have the time to look into this. But if someone were to take a stab at this then I hope it's as simple as just addressing the above 2 items.

@Zajn Zajn deleted the zajn/add-faraday-dependency branch June 1, 2022 21:36
@Zajn
Copy link
Contributor Author

Zajn commented Jun 1, 2022

@ruckus @TomA-R I opened #578 to upgrade Faraday.

All tests passed on my branch locally, but I wasn't sure what else needed to be tested, so I didn't add anything. If you have time to give it a look and see anything that you think should be tested, let me know and I can try and add something later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oauth2 1.4.8 update causes NoMethodError: undefined method `dependency' for Gzip:Class
4 participants