webui: Enable serviceAccountName in rucio-webui deployment #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the optional `serviceAccountName` in rucio-webui deployment
d-ylee
force-pushed
the
webui-serviceaccount
branch
from
d4e9dbd to
e2e0cb3
Compare
d-ylee
requested review from
rdimaio
and removed request for
maany and
bjwhite-fnal
d-ylee
changed the title
maany
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the optional
serviceAccountNamein rucio-webui deployment. This is similar to what is seen inrucio-serverhttps://github.com/d-ylee/helm-charts/blob/fd2d43541767c3d923c60ded3ce2a77d4ab0bfa4/charts/rucio-server/templates/deployment.yaml#L35-L37
and several of the
rucio-daemonsAt FNAL, we are copying some files from an
initContainer, which requires us to use a specific serviceAccount.