Fix for #122, #121 and #175 on Rails 4 branch #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeodor
changed the title
|
For what it's worth, this test that's failing on travis fails before this change. If I |
Ruby 1.9's version of `Object.const_get` does not support namespaced constants, so this commit replaces it with `ActiveSupport`'s `#constantize` method. The tests were failing running JRuby on 1.9 mode. CRuby was not failing because it is not tested against 1.9.
|
But I fixed it anyway. That last commit should do it. |
|
Thanks @codeodor! |
|
My pleasure! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure whether #121 got closed because this fix wasn't desired for the Rails 4 branch, or just because it was so similar to #122 that it looked like a duplicate, so while I was fixing the issue brought up by @joshuapinter I thought I'd add the test for the Rails 4 branch as well.