Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update provenance component design #5330

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

segiddins
Copy link
Member

@segiddins segiddins commented Dec 12, 2024

With design from the figma

image image

Signed-off-by: Samuel Giddins [email protected]

With design from the figma

Signed-off-by: Samuel Giddins <[email protected]>
@segiddins segiddins requested a review from martinemde December 12, 2024 18:23
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.13%. Comparing base (5b8a493) to head (91eaff7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...p/views/components/version/provenance_component.rb 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5330      +/-   ##
==========================================
- Coverage   97.14%   97.13%   -0.01%     
==========================================
  Files         457      457              
  Lines        9561     9567       +6     
==========================================
+ Hits         9288     9293       +5     
- Misses        273      274       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@segiddins segiddins marked this pull request as ready for review December 12, 2024 18:45
@simi
Copy link
Member

simi commented Dec 12, 2024

Nice!

@segiddins segiddins merged commit 3f30c59 into master Dec 13, 2024
18 of 19 checks passed
@segiddins segiddins deleted the segiddins/update-provenance-component-design branch December 13, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants