Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lookbook & component tests #4407

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

segiddins
Copy link
Member

@segiddins segiddins commented Jan 30, 2024

To make it easier to iterate on development of phlex components

Extracted from #4367

image

To make it easier to iterate on development of phlex components
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c421a6) 96.99% compared to head (63a9fe8) 96.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4407   +/-   ##
=======================================
  Coverage   96.99%   96.99%           
=======================================
  Files         336      336           
  Lines        7514     7514           
=======================================
  Hits         7288     7288           
  Misses        226      226           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@segiddins segiddins marked this pull request as ready for review January 30, 2024 07:50
Copy link
Member

@martinemde martinemde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to try this locally too. I'll do that after merge. If we don't like it we could always rip it out later.

@segiddins segiddins merged commit a86c29f into master Jan 30, 2024
16 checks passed
@segiddins segiddins deleted the segiddins/add-lookbook-component-tests branch January 30, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants