Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Add git and branch options to bundle add #7127

Merged
1 commit merged into from
Apr 23, 2019

Conversation

tokachev
Copy link

@tokachev tokachev commented Apr 13, 2019

Closes #6841 These changes will allow to add a gem with the git or branch options.

bundle add redis --git "https://github.com/redis/redis-rb" --branch "staging"

The result in Gemfile will be:

gem "redis", "~> 4.0", :git => "https://github.com/redis/redis-rb", :branch => "staging"

@welcome
Copy link

welcome bot commented Apr 13, 2019

Thanks for opening a pull request and helping make Bundler better! Someone from the Bundler team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use Travis CI to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Travis CI in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #bundler channel on Slack.

For more information about contributing to the Bundler project feel free to review our CONTRIBUTING guide

Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! ❤️

@deivid-rodriguez
Copy link
Member

One question, you said "related to" #6841 because this doesn't fully close that issue?

@tokachev
Copy link
Author

@deivid-rodriguez No, it fully closes that issue. I just used the wrong word)

@deivid-rodriguez
Copy link
Member

Thanks @tokachev!

@bundlerbot r+

ghost pushed a commit that referenced this pull request Apr 23, 2019
7127: Add git and branch options to `bundle add` r=deivid-rodriguez a=tokachev

Closes #6841 These changes will allow to add a gem with the git or branch options.

```
bundle add redis --git "https://github.com/redis/redis-rb" --branch "staging"
```

The result in Gemfile will be: 
```
gem "redis", "~> 4.0", :git => "https://github.com/redis/redis-rb", :branch => "staging"
```

Co-authored-by: Baumgarten <[email protected]>
@ghost
Copy link

ghost commented Apr 23, 2019

Build succeeded

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bundle add for git: and branch:?
2 participants