This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Complete some missing specs #7082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Straightforward and affects tests only, so merging! @bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Apr 1, 2019
7082: Complete some missing specs r=deivid-rodriguez a=deivid-rodriguez This is a follow up to #7052. ### What was the end-user problem that led to this PR? The problem was that the `Bundle.with_clean_env` & `Bundle.with_original_env` family was missing some deprecation specs, and also the specs were spread out across different files. ### What is your fix for the problem, implemented in this PR? My fix is to add the missing specs, and centralize them in the deprecation specs file. Co-authored-by: David Rodríguez <[email protected]>
Build succeeded |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #7052.
What was the end-user problem that led to this PR?
The problem was that the
Bundle.with_clean_env&Bundle.with_original_envfamily was missing some deprecation specs, and also the specs were spread out across different files.What is your fix for the problem, implemented in this PR?
My fix is to add the missing specs, and centralize them in the deprecation specs file.