This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Make bundle clean clean git extension directories
#7059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
approved these changes
Mar 21, 2019
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Mar 27, 2019
7059: Make `bundle clean` clean git extension directories r=hsbt a=dylanahsmith Fixes #7058 This PR fixes it by adding the native extension directories for git gems to the ones for non-git gems. This is used to get the unused extension directories (`stale_extension_dirs = extension_dirs - spec_extension_paths`) which was already excluding extension directories for git gems. Co-authored-by: Dylan Thacker-Smith <[email protected]>
Build succeeded |
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7058
This PR fixes it by adding the native extension directories for git gems to the ones for non-git gems. This is used to get the unused extension directories (
stale_extension_dirs = extension_dirs - spec_extension_paths) which was already excluding extension directories for git gems.