This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Ignore Object =~ warnings.
#6923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can merge this after merging #6315 |
Ruby 2.7.0-dev added the warnings about Object =~. We need to avoid it.
hsbt
force-pushed
the
ignore-object-regex
branch
from
6dee08c to
93c3fc4
Compare
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Jan 23, 2019
6923: Ignore `Object =~` warnings. r=segiddins a=hsbt ### What was the end-user problem that led to this PR? We faced a lot of warnings with `rake spec` of bundler repository. ### What was your diagnosis of the problem? Ruby 2.7.0-dev added the warnings for `Object =~` comparison. ### What is your fix for the problem, implemented in this PR? I added the additional condition and bump a version of the development dependency. Co-authored-by: SHIBATA Hiroshi <[email protected]>
Build succeeded |
ghost
merged commit
|
@segiddins Thanks! |
ghost
pushed a commit
that referenced
this pull request
Jan 24, 2019
6924: Bump rake version to 12.0 on gemspec template r=hsbt a=hsbt ### What was the end-user problem that led to this PR? Related with #6923 ### What was your diagnosis of the problem? rake-10.x displayed the warnings of `Object =~` with Ruby 2.7.0-dev. ### What is your fix for the problem, implemented in this PR? Rake 10.0 is EOL. I'm a maintainer of Rake. I have no plan to avoid `Object =~` warnings with Rake 10.x. Co-authored-by: SHIBATA Hiroshi <[email protected]>
Closed
colby-swandale
pushed a commit
that referenced
this pull request
Apr 1, 2019
6923: Ignore `Object =~` warnings. r=segiddins a=hsbt ### What was the end-user problem that led to this PR? We faced a lot of warnings with `rake spec` of bundler repository. ### What was your diagnosis of the problem? Ruby 2.7.0-dev added the warnings for `Object =~` comparison. ### What is your fix for the problem, implemented in this PR? I added the additional condition and bump a version of the development dependency. Co-authored-by: SHIBATA Hiroshi <[email protected]> (cherry picked from commit e66e6f2)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
We faced a lot of warnings with
rake specof bundler repository.What was your diagnosis of the problem?
Ruby 2.7.0-dev added the warnings for
Object =~comparison.What is your fix for the problem, implemented in this PR?
I added the additional condition and bump a version of the development dependency.