This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
[CLI::Gem] Add a --rubocop option #6455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great!! @bundlerbot r+ |
|
📌 Commit d3275e8 has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Apr 15, 2018
…colby-swandale [CLI::Gem] Add a --rubocop option Based upon #6451. ### What was the end-user problem that led to this PR? The problem was I always have to remember how to add RuboCop to my Rakefile when I set up a new gem. ### What was your diagnosis of the problem? My diagnosis was that RuboCop has become enough of a community standard that it makes sense to offer it in `bundle gem`. ### What is your fix for the problem, implemented in this PR? My fix adds an option to `bundle gem` to add in RuboCop, in the same way options like `:coc`and `:mit` are handled. ### Why did you choose this fix out of the possible options? I chose this fix because it does not require bundler have an opinion on _how_ rubocop is configured.
|
💔 Test failed - status-travis |
|
Oh, i didn't notice the failing specs |
|
I think this just needs a rebase? |
segiddins
force-pushed
the
segiddins/bundle-gem-rubocop-option
branch
from
d3275e8 to
ea6d542
Compare
|
This looks like it's rebased with some other commits it shouldn't have. |
|
Nah I just need to rebase the other branch, I think |
|
Oh i didn't notice that this wasn't going into master. |
segiddins
force-pushed
the
segiddins/bundle-gem-version-file
branch
from
880d379 to
ea0a09b
Compare
|
Rebased |
koic
reviewed
Apr 19, 2018
lib/bundler/templates/newgem/VERSION
Outdated
| @@ -0,0 +1 @@ | |||
| 0.1.0 | |||
There was a problem hiding this comment.
I thought it would be better to add a newline for EOF.
segiddins
force-pushed
the
segiddins/bundle-gem-version-file
branch
from
ea0a09b to
225c68e
Compare
|
☔ The latest upstream changes (presumably 225c68e) made this pull request unmergeable. Please resolve the merge conflicts. |
segiddins
force-pushed
the
segiddins/bundle-gem-rubocop-option
branch
from
ea6d542 to
2df9564
Compare
|
@indirect r? |
|
looks good, @bundlerbot r+ |
|
📌 Commit 2df9564 has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Jun 4, 2018
…indirect [CLI::Gem] Add a --rubocop option Based upon #6451. ### What was the end-user problem that led to this PR? The problem was I always have to remember how to add RuboCop to my Rakefile when I set up a new gem. ### What was your diagnosis of the problem? My diagnosis was that RuboCop has become enough of a community standard that it makes sense to offer it in `bundle gem`. ### What is your fix for the problem, implemented in this PR? My fix adds an option to `bundle gem` to add in RuboCop, in the same way options like `:coc`and `:mit` are handled. ### Why did you choose this fix out of the possible options? I chose this fix because it does not require bundler have an opinion on _how_ rubocop is configured.
|
💔 Test failed - status-travis |
|
@bundlerbot retry |
bundlerbot
added a commit
that referenced
this pull request
Jun 4, 2018
…indirect [CLI::Gem] Add a --rubocop option Based upon #6451. ### What was the end-user problem that led to this PR? The problem was I always have to remember how to add RuboCop to my Rakefile when I set up a new gem. ### What was your diagnosis of the problem? My diagnosis was that RuboCop has become enough of a community standard that it makes sense to offer it in `bundle gem`. ### What is your fix for the problem, implemented in this PR? My fix adds an option to `bundle gem` to add in RuboCop, in the same way options like `:coc`and `:mit` are handled. ### Why did you choose this fix out of the possible options? I chose this fix because it does not require bundler have an opinion on _how_ rubocop is configured.
|
💔 Test failed - status-travis |
|
@bundlerbot retry |
|
Only changes I made is pointing this PR to master, and adding some missing spaces to the CLI message. |
|
1.8.7 matrix entry failed, not sure why. I restarted it. |
ixti
reviewed
Oct 5, 2018
| @@ -54,4 +54,7 @@ Gem::Specification.new do |spec| | |||
| <%- if config[:test] -%> | |||
| spec.add_development_dependency "<%= config[:test] %>", "~> <%= config[:test_framework_version] %>" | |||
| <%- end -%> | |||
| <%- if config[:rubocop] -%> | |||
| spec.add_development_dependency "rubocop" | |||
| <%- end -%> | |||
There was a problem hiding this comment.
Worth also to add rubocop-rspec if chosen test framework is rspec IMO
|
This is going to have to wait for bundler 2 to be released before we can merge it. For some reason the ruby parser in 1.8.7 is locking up in |
|
This should be ok to merge now. I can work on getting this over the line. |
koic
reviewed
Jul 12, 2019
koic
reviewed
Jul 12, 2019
|
@colby-swandale, are you still planning to wrap up this PR? I can follow up if you are very busy 👍. |
deivid-rodriguez
force-pushed
the
segiddins/bundle-gem-rubocop-option
branch
from
82faeba to
1d2d5b0
Compare
Merged
deivid-rodriguez
force-pushed
the
segiddins/bundle-gem-rubocop-option
branch
from
1d2d5b0 to
0448ad5
Compare
ghost
pushed a commit
that referenced
this pull request
Oct 7, 2019
7373: Refactor new gem specs r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that I rebased #6455 and I had trouble getting the specs to pass. ### What was your diagnosis of the problem? My diagnosis was that the new gemspecs could use a refactor. ### What is your fix for the problem, implemented in this PR? My fix is to refactor these specs so that they are easier to read and modify. Co-authored-by: David Rodríguez <[email protected]>
deivid-rodriguez
force-pushed
the
segiddins/bundle-gem-rubocop-option
branch
from
0448ad5 to
2210cad
Compare
deivid-rodriguez
force-pushed
the
segiddins/bundle-gem-rubocop-option
branch
from
2210cad to
f821c75
Compare
|
@colby-swandale Forgot to mention that I updated this PR and it should be finally ready, in case you want to have a look at it before merging. |
deivid-rodriguez
pushed a commit
that referenced
this pull request
Nov 7, 2019
7373: Refactor new gem specs r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that I rebased #6455 and I had trouble getting the specs to pass. ### What was your diagnosis of the problem? My diagnosis was that the new gemspecs could use a refactor. ### What is your fix for the problem, implemented in this PR? My fix is to refactor these specs so that they are easier to read and modify. Co-authored-by: David Rodríguez <[email protected]> (cherry picked from commit 6ceec55)
|
@bundlerbot merge |
ghost
pushed a commit
that referenced
this pull request
Nov 8, 2019
6455: [CLI::Gem] Add a --rubocop option r=deivid-rodriguez a=segiddins Based upon #6451. ### What was the end-user problem that led to this PR? The problem was I always have to remember how to add RuboCop to my Rakefile when I set up a new gem. ### What was your diagnosis of the problem? My diagnosis was that RuboCop has become enough of a community standard that it makes sense to offer it in `bundle gem`. ### What is your fix for the problem, implemented in this PR? My fix adds an option to `bundle gem` to add in RuboCop, in the same way options like `:coc`and `:mit` are handled. ### Why did you choose this fix out of the possible options? I chose this fix because it does not require bundler have an opinion on _how_ rubocop is configured. Co-authored-by: Samuel Giddins <[email protected]>
Build succeeded |
ghost
merged commit
4 tasks
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based upon #6451.
What was the end-user problem that led to this PR?
The problem was I always have to remember how to add RuboCop to my Rakefile when I set up a new gem.
What was your diagnosis of the problem?
My diagnosis was that RuboCop has become enough of a community standard that it makes sense to offer it in
bundle gem.What is your fix for the problem, implemented in this PR?
My fix adds an option to
bundle gemto add in RuboCop, in the same way options like:cocand:mitare handled.Why did you choose this fix out of the possible options?
I chose this fix because it does not require bundler have an opinion on how rubocop is configured.