Remove comment with timestamp on bundle add
#6300
Conversation
|
Thanks for opening a pull request and helping make Bundler better! Someone from the Bundler team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality. We use Travis CI to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Travis CI in the PR status window below. If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #bundler channel on Slack. For more information about contributing to the Bundler project feel free to review our CONTRIBUTING guide |
| @@ -84,9 +84,6 @@ def build_gem_lines(conservative_versioning) | |||
| def append_to(gemfile_path, new_gem_lines) | |||
| gemfile_path.open("a") do |f| | |||
| f.puts | |||
| if @options["timestamp"] || @options["timestamp"].nil? | |||
There was a problem hiding this comment.
we should probably give a deprecation warning is the timestamp option is given via the command line though?
|
The timestamp is honestly purely a leftover implementation detail from |
|
Thanks! @bundlerbot r+ |
|
📌 Commit c518c36 has been approved by |
…dale Remove comment with timestamp on `bundle add` As discussed on #6193 this PR simply removes the comment timestamp when adding a gem via command line.
|
☀️ Test successful - status-travis |
|
Is this something that can be backported to v1.16, or is it only slated for v2? |
|
This will be part of the next bundler patch release. |
As discussed on #6193 this PR simply removes the comment timestamp when adding a gem via command line.