This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Require socket in the file that needs it #5534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd love ideas on how to test it is necessary. |
|
Something similar happened to me on #4083 and I didn't add a test. Not sure if it's necessary (given that the file actually needs |
andremedeiros
suggested changes
Mar 23, 2017
lib/bundler/mirror.rb
Outdated
| @@ -1,4 +1,7 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
lib/bundler/mirror.rb
Outdated
| @@ -1,4 +1,7 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| require 'socket' | |||
There was a problem hiding this comment.
Can you use double quotes here? (inline with the rest of this codebase)
rafaelfranca
force-pushed
the
fix-mirror-socket
branch
from
0b49f96 to
457ec14
Compare
andremedeiros
approved these changes
Mar 23, 2017
|
@bundlerbot r+ |
|
📌 Commit 457ec14 has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Mar 23, 2017
Require socket in the file that needs it Closes #5533
|
☀️ Test successful - status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5533