This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a bug that I reported for Rake test problem.
First,
Bundler::Plugin
uses cascadingautoload
forBundler::Plugin::API
andBundler::Plugin::API::Source
.Secondly, Bundler uses monkey patch for RubyGems loading logic, thus
Gem::Specification#full_gem_path
is overridden.Next, if a module is loaded by
require
in RubyGems with Bundler's monkey patch, theGem::Specification#full_gem_path
that usesBundler::Plugin::API::Source
is called in it. Butbundler/plugin/api/source
usesrequire
beforeBundler::Plugin::API::Source
is defined. RubyGems loading logic runs again by therequire
.Bundler::Plugin::API::Source
is not defined yet.Gem::Specification#full_gem_path
is called again, and it usesBundler::Plugin::API::Source
. Theautoload
is skipped after 2nd call. So exception is occurred.This Pull Request bypasses the recursive RubyGems require.