[RubygemsExt] Add missing require rubygems/source #4944
Conversation
The change referenced below as released in 1.13.0.rc.2, may attempt to reference Gem::Source without it being loaded, resulting in: [!] There was an error parsing `Gemfile`: [!] There was an error while loading `elided.gemspec`: uninitialized constant Gem::Source. Bundler cannot continue. Observed this on ruby 2.2.5 with stock rubygems 2.4.5 as well as upgraded rubygems 2.6.6. Add this require. commit f9de70e Author: Samuel Giddins <[email protected]> AuthorDate: Sun Jul 10 11:06:49 2016 -0300 Commit: Samuel Giddins <[email protected]> CommitDate: Tue Jul 19 17:13:19 2016 -0500 [RubygemsExt] return Source::Installed from #source when appropriate
|
Hmm... might not be that simple, as this suggests: ...that Gem::Source doesn't exist until rubygems 2.0.0? |
|
Please add a test for the bug this is addressing -- thanks! |
|
@segiddins I'll try to do that. There are CI tests for Rubygems as far back as 1.6.2 however, and there is no Gem::Source as referenced as far as I can tell in Rubygems versions before 2.0.0. Can you please comment on that? |
|
The source method didn't exist before then either |
|
Death by linter. Wish I new how to make rubocop happy when intentionally swallowing a load error. |
|
Hi, I faced same error with Ruby 2.2 and 2.1 on travis builds. see. https://travis-ci.org/ruby/rake/builds/158902251 |
|
@homu r+ |
|
📌 Commit 34404bb has been approved by |
…irect [RubygemsExt] Add missing require rubygems/source The change referenced below as released in 1.13.0.rc.2, may attempt to reference Gem::Source without it being loaded, resulting in: ~~~ [!] There was an error parsing `Gemfile`: [!] There was an error while loading `elided.gemspec`: uninitialized constant Gem::Source. Bundler cannot continue. ~~~ Observed this on ruby 2.2.5 with stock rubygems 2.4.5 as well as upgraded rubygems 2.6.6. Add this require. f9de70e by @segiddins: > [RubygemsExt] return Source::Installed from #source when appropriate
|
I don't think we should be merging this without a test |
|
☀️ Test successful - status |
|
Sorry gents, I have not been able to reduce the error to a spec in bundler's environment. @hsbt's rake repro. gave me some hope, with a public code base, but again I can not seem to replicate the same (feature usage? load order?) in a bundler spec. Thanks for the merge. |
|
Have same error using ruby-2.3.0 and bundler-1.13.0 on continuous integration. |
…irect [RubygemsExt] Add missing require rubygems/source The change referenced below as released in 1.13.0.rc.2, may attempt to reference Gem::Source without it being loaded, resulting in: ~~~ [!] There was an error parsing `Gemfile`: [!] There was an error while loading `elided.gemspec`: uninitialized constant Gem::Source. Bundler cannot continue. ~~~ Observed this on ruby 2.2.5 with stock rubygems 2.4.5 as well as upgraded rubygems 2.6.6. Add this require. f9de70e by @segiddins: > [RubygemsExt] return Source::Installed from #source when appropriate (cherry picked from commit 3b5d047)
The change referenced below as released in 1.13.0.rc.2, may attempt to reference Gem::Source without it being loaded, resulting in:
Observed this on ruby 2.2.5 with stock rubygems 2.4.5 as well as upgraded rubygems 2.6.6. Add this require.
f9de70e by @segiddins: