Add check of Dir.home's permission #4886
Conversation
| @@ -136,6 +136,10 @@ def print_major_deprecations! | |||
| major_deprecation("Bundler will only support rubygems >= 2.0, you are running #{Bundler.rubygems.version}") | |||
| end | |||
|
|
|||
| def check_home_dir_permissions | |||
| raise PathError, "There was an error while trying to use your home path #{Dir.home}" unless File.writable?(Dir.home) | |||
There was a problem hiding this comment.
this should specifically mention that the home directory must exist & be writable
|
@allenzhao ping? |
|
I think Bundler should just work, even if home directories are unwritable or do not exist. User-level settings should not be persisted, and cached files like the compact index and gem download cache should go into |
|
@indirect So what should be the solution here? |
|
@allenzhao there are RuboCop failures in addition |
Signed-off-by: Zehan Zhao <[email protected]>
|
@allenzhao I added notes to the list ticket #4871:
I think it means we will want to fix this problem in a different way, with PRs that solve those two problems. I would be very happy to have you work on those, and if you would like me to write a more detailed description of how that should work, I am happy to do it, just let me know. |
|
@indirect Please do by opening a new issue, and I will close this PR. |
Fallback to a temp dir when the home directory is not usable Closes #4778 This is an alternative to #4886 \c @allenzhao @indirect
Ref #4778