This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2k
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Hmmm I was actually thinking of a flag on |
I personally prefer settings to flags for things that are rarely needed |
I was thinking of the flag for the use case where one particular command only works with load disabled, but you don't want to lose the performance improvements generally. But shipping a setting seems fine for now, you can do a one-off using env. |
@homu r+ |
📌 Commit 3506b72 has been approved by |
homu
added a commit
that referenced
this pull request
Aug 11, 2016
Add a setting for disable_exec_load See #4852
💔 Test failed - status |
segiddins
force-pushed
the
seg-disable-exec-load
branch
from
August 16, 2016 22:02
3506b72
to
39d10a6
Compare
@homu r+ |
📌 Commit 39d10a6 has been approved by |
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Aug 17, 2016
Add a setting for disable_exec_load See #4852
This was referenced Aug 17, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4852