Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Add a setting for disable_exec_load #4869

Merged
merged 2 commits into from
Aug 17, 2016
Merged

Add a setting for disable_exec_load #4869

merged 2 commits into from
Aug 17, 2016

Conversation

segiddins
Copy link
Member

See #4852

@indirect indirect mentioned this pull request Aug 10, 2016
11 tasks
@indirect
Copy link
Member

Hmmm I was actually thinking of a flag on exec, like exec --no-load. This is good too, though. Document this setting in man/bundle_config and I think this is good!

@segiddins
Copy link
Member Author

I personally prefer settings to flags for things that are rarely needed

@indirect
Copy link
Member

I was thinking of the flag for the use case where one particular command only works with load disabled, but you don't want to lose the performance improvements generally. But shipping a setting seems fine for now, you can do a one-off using env.

@indirect
Copy link
Member

@homu r+

@homu
Copy link
Contributor

homu commented Aug 11, 2016

📌 Commit 3506b72 has been approved by indirect

homu added a commit that referenced this pull request Aug 11, 2016
@homu
Copy link
Contributor

homu commented Aug 11, 2016

⌛ Testing commit 3506b72 with merge 28257dd...

@homu
Copy link
Contributor

homu commented Aug 12, 2016

💔 Test failed - status

@segiddins segiddins force-pushed the seg-disable-exec-load branch from 3506b72 to 39d10a6 Compare August 16, 2016 22:02
@segiddins
Copy link
Member Author

@homu r+

@homu
Copy link
Contributor

homu commented Aug 16, 2016

📌 Commit 39d10a6 has been approved by segiddins

@homu
Copy link
Contributor

homu commented Aug 17, 2016

⚡ Test exempted - status

@homu homu merged commit 39d10a6 into master Aug 17, 2016
homu added a commit that referenced this pull request Aug 17, 2016
@segiddins segiddins deleted the seg-disable-exec-load branch August 17, 2016 00:20
@coilysiren coilysiren modified the milestone: Release Archive Sep 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants