Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Add OpenSSL::OPENSSL_VERSION to bundle env #4624

Merged
merged 1 commit into from
Aug 24, 2016

Conversation

chrismo
Copy link
Contributor

@chrismo chrismo commented May 27, 2016

No description provided.

@segiddins
Copy link
Member

OpenSSL need not be installed

@chrismo
Copy link
Contributor Author

chrismo commented May 30, 2016

True. Git and RVM aren't requirements - I thought adding this might help for troubleshooting common https cases.

@segiddins
Copy link
Member

My point was more that we need to handle the OpenSSL module not being defined.

@chrismo
Copy link
Contributor Author

chrismo commented May 31, 2016

Ah, I misunderstood - makes sense.

@indirect
Copy link
Member

indirect commented Aug 8, 2016

@chrismo @segiddins could one of you patch this up so we can merge it? I think this would be really valuable for debugging purposes.

@chrismo chrismo force-pushed the openssl_version_in_bundle_env branch from f15c46b to 0d2b7cc Compare August 10, 2016 05:00
@indirect indirect mentioned this pull request Aug 11, 2016
23 tasks
@segiddins
Copy link
Member

@homu r+

@homu
Copy link
Contributor

homu commented Aug 24, 2016

📌 Commit 0d2b7cc has been approved by segiddins

@homu
Copy link
Contributor

homu commented Aug 24, 2016

⌛ Testing commit 0d2b7cc with merge 85f1987...

homu added a commit that referenced this pull request Aug 24, 2016
Add OpenSSL::OPENSSL_VERSION to `bundle env`
@segiddins
Copy link
Member

Sorry @chrismo, I didn't see you'd rebased this

@chrismo
Copy link
Contributor Author

chrismo commented Aug 24, 2016

no worries, you've been busy :)

@homu
Copy link
Contributor

homu commented Aug 24, 2016

☀️ Test successful - status

@homu homu merged commit 0d2b7cc into rubygems:master Aug 24, 2016
@coilysiren coilysiren modified the milestone: Release Archive Sep 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants