This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Distinguish CI command runs #3646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch add CI information on the user_agent in order for us to track if a given command was run by a CI, as discussed in rubygems#3233.
|
|
||
| describe "include CI information" do | ||
| it "from one CI" do | ||
| ENV["JENKINS_URL"] = "foo" |
There was a problem hiding this comment.
It will be better to keep and reassign old value (instead of forcing nil).
There was a problem hiding this comment.
Of course! Silly me!
|
Can I have this job on travis run again? I just tried locally and it worked with ruby 2.2.2. Looking at the travis log, it seems like a transient error. It have messages like this: |
|
restarted the build, I think it was failing because RubyGems master was broken |
|
@indirect Thank you! |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch add CI information on the user_agent in order for us to track
if a given command was run by a CI, as discussed in #3233.