This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Resolver bug fixes and improvements #3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Bundler is aggressive to try different versions of exsiting gem parents before exhausting different versions of parents of current conflicting gem. By making sure we travase the current conflicting dependency tree before trying to make use of exsiting (activated) gem dependency tree, we reduce the number of conflicts and activation of gems older then the latest compitable version. However, a long term solution would be to make the resolver smarter by making it understand if current requirement conflict is caused by either by it's parent or existing gem parent by looking at each of their dependency requirements.
Currently Bundler tries different versions of current gem and than it's parents and finally existing gems. However, when trying different versions of current gem will cause it to conflict with existing gem version and sometimes it will be unable to resolve the dependency tree correctly. Now, we will try to resolve current gems parent first then current gem and then finally the exisiting gems.
…rent version" This reverts commit d672064.
|
@Who828 there is a failing test! can you check it out? |
|
@Who828 ping for you to check out the failing test when you have a minute. I would love to release 1.7.8 with these fixes soon. |
Who828
force-pushed
the
resolver_bug_fix
branch
from
fe56ec2 to
2781226
Compare
indirect
added a commit
that referenced
this pull request
Dec 8, 2014
Resolver bug fixes and improvements Conflicts: CHANGELOG.md
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes most (all?) of the open resolver issues on Github.