This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Subprocess support for with_original_env #2390
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2369
The main symptom that led me to encounter it was that I was unable to perform a
gem install
to the system location within abundle exec
'd process (chef, in this case) -PATH
and friends were being bashed over becauseORIGINAL_ENV
was being read from within the subprocess and not passed through.I'm unsure whether I should be preserving the
_ORIGINAL_GEM_PATH
env var for compatibility in this.Also, f15cf14 is independent of this feature (the example group was pointless in its previous form), if you want to cherry pick separately