bundle update is not updating vendor cached git gems

[bughit]

in this example timecop is locked at 6773a731104c96142e207bbc20a24c9a2d012081 which is the penultimate commit, bundle update should update it to the last commit b0a84cd674a380fb76285320b6d73088fc87f5df, but does nothing.

related to #5398.

bundle update timecop
Resolving dependencies...
Using timecop 0.8.0 from git://github.com/travisjeffery/timecop.git (at /tmp/bundler_cache_bug/vendor/cache/timecop-6773a731104c@6773a73)
Using bundler 1.14.3
Updating files in vendor/cache
Bundle updated!

Environment

Bundler   1.14.3
Rubygems  2.6.8
Ruby      2.4.0p0 (2016-12-24 revision 57164) [x86_64-linux]
Git       2.11.0
Platform  x86_64-linux

Bundler settings

git.allow_insecure
  Set for the current user (/home/alex/.bundle/config): "true"
cache_all
  Set for your local app (/tmp/bundler_cache_bug/.bundle/config): "true"

Gemfile

Gemfile

gem 'timecop', github: 'travisjeffery/timecop'

Gemfile.lock

GIT
  remote: git://github.com/travisjeffery/timecop.git
  revision: 6773a731104c96142e207bbc20a24c9a2d012081
  specs:
    timecop (0.8.0)

GEM
  specs:

PLATFORMS
  ruby

DEPENDENCIES
  timecop!

BUNDLED WITH
   1.14.3

[bughit]

if you delete timecop-6773a731104c from the cache, bundle update does fetch the latest commit but caches it the wrong folder (timecop-6773a731104c)

so here's what's currently required to update a cached git gem

1. manually delete it from the cache
2. bundle update it
3. since its cache folder is wrong, delete it again from the cache
4. bundle install
5. now it's cached in the right place

[colby-swandale]

Sorry for the delay!

I ran through your instructions but was unable to replicate your problem

› cat Gemfile
source 'https://rubygems.org'

gem 'timecop', github: 'travisjeffery/timecop'

› cat Gemfile.lock
GIT
  remote: git://github.com/travisjeffery/timecop.git
  revision: 6773a731104c96142e207bbc20a24c9a2d012081
  specs:
    timecop (0.8.0)

GEM
  remote: https://rubygems.org/
  specs:

PLATFORMS
  ruby

DEPENDENCIES
  timecop!

BUNDLED WITH
   1.14.3

› bundle
The git source `git://github.com/travisjeffery/timecop.git` uses the `git` protocol, which transmits data without encryption. Disable this warning with `bundle config git.allow_insecure true`, or switch to the `https` protocol to keep your data secure.
Using timecop 0.8.0 from git://github.com/travisjeffery/timecop.git (at master@6773a73)
Using bundler 1.14.3
Bundle complete! 1 Gemfile dependency, 2 gems now installed.
Use `bundle show [gemname]` to see where a bundled gem is installed.

Bundle Update

› bundle update
The git source `git://github.com/travisjeffery/timecop.git` uses the `git` protocol, which transmits data without encryption. Disable this warning with `bundle config git.allow_insecure true`, or switch to the `https` protocol to keep your data secure.
Fetching git://github.com/travisjeffery/timecop.git
Fetching gem metadata from https://rubygems.org/
Fetching version metadata from https://rubygems.org/
Resolving dependencies...
Using timecop 0.8.0 from git://github.com/travisjeffery/timecop.git (at master@b0a84cd)
Using bundler 1.14.3
Bundle updated!

› cat Gemfile.lock
GIT
  remote: git://github.com/travisjeffery/timecop.git
  revision: b0a84cd674a380fb76285320b6d73088fc87f5df
  specs:
    timecop (0.8.0)

GEM
  remote: https://rubygems.org/
  specs:

PLATFORMS
  ruby

DEPENDENCIES
  timecop!

BUNDLED WITH
   1.14.3

[bughit]

I don't think the gem was project vendor cached for you

you need to have `vendor\cache\timecop-6773a731104c' in the project folder, before you run bundle update timecop

bundle package --all should get it there

after that bundle show timecop' will point to vendor\cache\timecop-6773a731104c`

[colby-swandale]

Thanks, i can replicate that behaviour now.

[mctaylorpants]

I saw this over on #4871 - currently working on a fix.