Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Handle ruby patch level being -1 #4317

Closed
segiddins opened this issue Feb 23, 2016 · 4 comments
Closed

Handle ruby patch level being -1 #4317

segiddins opened this issue Feb 23, 2016 · 4 comments
Assignees
@RochesterinNYC

Comments

@segiddins
Copy link
Member

This is what happens on ruby-head, for instance. So Bundler::RubyVersion needs to handle it
@segiddins
Copy link
Member Author

@RochesterinNYC any interest in looking into this one?

@RochesterinNYC
Copy link
Contributor

Sure! I'd need a bit more context on what the issue exactly is though. Given a ruby version v##.##.z, what is the format for z that Bundler::RubyVersion can't handle?

@segiddins
Copy link
Member Author

No, not the patch part of the version. The RUBY_PATCHLEVEL constant is -1

@RochesterinNYC
Copy link
Contributor

Ah gotcha, thanks for the clarification.

@RochesterinNYC RochesterinNYC self-assigned this Feb 26, 2016
@RochesterinNYC RochesterinNYC mentioned this issue Feb 27, 2016
Merged
homu added a commit that referenced this issue Feb 27, 2016
@homu
Auto merge of #4324 - RochesterinNYC:allow-bundler-ruby-version-neg-1…
a69ec8f 
…-patchlevel-handling, r=indirect

Allow `Bundler::RubyVersion` to handle -1 for RUBY_PATCHLEVEL

Fixes how the `matches?` method in `Bundler::RubyVersion` handles a `RUBY_PATCHLEVEL` of `-1`, which seems to be the case with ruby-head.

Closes #4317
indirect pushed a commit that referenced this issue Mar 12, 2016
@RochesterinNYC @indirect
Allow Bundler::RubyVersion to handle RUBY_PATCHLEVEL of -1
0a7e5e3 
- Closes #4317
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RochesterinNYC RochesterinNYC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RochesterinNYC @segiddins