Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Add pkg to Rake's CLOBBER FileList #3676

Closed
jasonkarns opened this issue May 26, 2015 · 4 comments · Fixed by #4022
Closed

Add pkg to Rake's CLOBBER FileList #3676

jasonkarns opened this issue May 26, 2015 · 4 comments · Fixed by #4022

Comments

@jasonkarns
Copy link
Contributor

Bundler's gem_tasks are quite helpful. But the first thing that needs added to a new gem's Rakefile is frequently require 'rake/clean' and CLOBBER.include 'pkg'

Since 'pkg' is hardcoded into the build task, might it also be handy to pre-populate the CLOBBER FileList with 'pkg' as well?

@indirect
Copy link
Member

It might be handy... can you elaborate on why you need to clobber pkg? I never do, and the only side effect seems to be ending up with old versions of the gem sitting in pkg...

@jasonkarns
Copy link
Contributor Author

"need" is a bit strong. It's mostly just the urge to keep things tidy. And
a bit of habit. I typically make clean or npm run clean or rake clean.

Of course, in keeping with rake's fine distinction of clean vs clobber, I
use clobber for gems. (clean being for temporary/intermediate files,
clobber being for resulting/generated files)

So there's no particular reason why I have the compulsion for cleaning. But
given that rake has default semantics for clean, I figured it'd be worth
considering applying those semantics to bundler's tasks.

On Tue, May 26, 2015 at 3:36 PM, André Arko [email protected]
wrote:

It might be handy... can you elaborate on why you need to clobber pkg? I
never do, and the only side effect seems to be ending up with old versions
of the gem sitting in pkg...


Reply to this email directly or view it on GitHub
#3676 (comment).

@indirect
Copy link
Member

Yeah, seems reasonable. Send a PR?

On Tue, May 26, 2015 at 12:42 PM, Jason Karns [email protected]
wrote:

"need" is a bit strong. It's mostly just the urge to keep things tidy. And
a bit of habit. I typically make clean or npm run clean or rake clean.
Of course, in keeping with rake's fine distinction of clean vs clobber, I
use clobber for gems. (clean being for temporary/intermediate files,
clobber being for resulting/generated files)
So there's no particular reason why I have the compulsion for cleaning. But
given that rake has default semantics for clean, I figured it'd be worth
considering applying those semantics to bundler's tasks.
On Tue, May 26, 2015 at 3:36 PM, André Arko [email protected]
wrote:

It might be handy... can you elaborate on why you need to clobber pkg? I
never do, and the only side effect seems to be ending up with old versions
of the gem sitting in pkg...


Reply to this email directly or view it on GitHub
#3676 (comment).


Reply to this email directly or view it on GitHub:
#3676 (comment)

@jasonkarns
Copy link
Contributor Author

sure thing!

On Tue, May 26, 2015 at 3:57 PM, André Arko [email protected]
wrote:

Yeah, seems reasonable. Send a PR?

On Tue, May 26, 2015 at 12:42 PM, Jason Karns [email protected]
wrote:

"need" is a bit strong. It's mostly just the urge to keep things tidy.
And
a bit of habit. I typically make clean or npm run clean or rake clean.
Of course, in keeping with rake's fine distinction of clean vs clobber, I
use clobber for gems. (clean being for temporary/intermediate files,
clobber being for resulting/generated files)
So there's no particular reason why I have the compulsion for cleaning.
But
given that rake has default semantics for clean, I figured it'd be worth
considering applying those semantics to bundler's tasks.
On Tue, May 26, 2015 at 3:36 PM, André Arko [email protected]
wrote:

It might be handy... can you elaborate on why you need to clobber pkg? I
never do, and the only side effect seems to be ending up with old
versions
of the gem sitting in pkg...


Reply to this email directly or view it on GitHub
<#3676 (comment)
.


Reply to this email directly or view it on GitHub:
#3676 (comment)


Reply to this email directly or view it on GitHub
#3676 (comment).

homu added a commit that referenced this issue Oct 4, 2015
include 'pkg/' in rake/clean's CLOBBER array

closes #3676
@homu homu closed this as completed in #4022 Oct 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants