Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Minitest template is wrong #3512

Closed
yuriihabrusiev opened this issue Mar 26, 2015 · 1 comment · Fixed by #3513
Closed

Minitest template is wrong #3512

yuriihabrusiev opened this issue Mar 26, 2015 · 1 comment · Fixed by #3513

Comments

@yuriihabrusiev
Copy link

Bundler creates test/test_#{my_gem}.rb file with class TestMyGem, but common practice is to create test/#{my_gem}_test.rb file with class MyGemTest.

Also - why test helper called minitest_helper?
@arthurnn
Copy link
Member

good catch @yuriihabrusiev .. I am working in a solution for this..
Indeed your 2 points should be followed.

arthurnn added a commit to arthurnn/bundler that referenced this issue Mar 26, 2015
@arthurnn
Improve Minitest gem template
68a863e 
Default minitest test/ folder structure should be:
- test/test_helper.rb
- test/GEMNAME_test.rb

[fixes rubygems#3512]
@arthurnn arthurnn mentioned this issue Mar 26, 2015
Merged
segiddins pushed a commit to segiddins/bundler that referenced this issue Mar 31, 2015
@arthurnn @segiddins
Improve Minitest gem template
fa8d009 
Default minitest test/ folder structure should be:
- test/test_helper.rb
- test/GEMNAME_test.rb

[fixes rubygems#3512]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Minitest gem template arthurnn/bundler
2 participants
@arthurnn @yuriihabrusiev