Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Bundler fails to load all rubygems plugins #2824

Closed
zebardy opened this issue Jan 16, 2014 · 2 comments
Closed

Bundler fails to load all rubygems plugins #2824

zebardy opened this issue Jan 16, 2014 · 2 comments

Comments

@zebardy
Copy link

zebardy commented Jan 16, 2014

When running with GEM_HOME set to a location and a rubygem plugin installed to that location the gem command will load the plugin, but bundler will not.

This is because bundler calls Gem.load_env_plugins (in bundler::CLI) but not Gem.load_plugins, rubygems calls both (in rubygems/gem_runner.rb). The simple solution is to add a Gem.load_plugins call along side the Gem.load_env_plugins call in bundler::CLI. A better solution (although a far bigger job) would be to move all interaction with the rubygems libraries to Bundler::RubygemsIntegration and have it initialize the rubygems libs appropriately for everything. This would simplify things greatly, but I'd rather have some feedback before attempting the bigger change.

@indirect
Copy link
Member

I'd be happy with calling both (after checking that they both exist). But it would be even better if you moved the calls to RubygemsIntegration. :)

On Thu, Jan 16, 2014 at 11:30 AM, zebardy [email protected]
wrote:

When running with GEM_HOME set to a location and a rubygem plugin installed to that location the gem command will load the plugin, but bundler will not.

This is because bundler calls Gem.load_env_plugins (in bundler::CLI) but not Gem.load_plugins, rubygems calls both (in rubygems/gem_runner.rb). The simple solution is to add a Gem.load_plugins call along side the Gem.load_env_plugins call in bundler::CLI. A better solution (although a far bigger job) would be to move all interaction with the rubygems libraries to Bundler::RubygemsIntegration and have it initialize the rubygems libs appropriately for everything. This would simplify things greatly, but I'd rather have some feedback before attempting the bigger change.

Reply to this email directly or view it on GitHub:
#2824

@coilysiren
Copy link
Contributor

Might be good to resurrect this once we start working on 3.0

@coilysiren coilysiren added this to the 3.0 milestone Apr 25, 2016
homu added a commit that referenced this issue Oct 3, 2016
…rect

[Installer] Load gem plugins when installing

Closes #2824 I think
@homu homu closed this as completed in #4954 Oct 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants