This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Auto merge of #5579 - bundler:seg-downloader-error, r=colby-swandale
[Downloader] Print underlying error in HTTPError Closes #5577
- Loading branch information
Showing
2 changed files
with
6 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -222,7 +222,7 @@ | |
|
||
it "should raise a Bundler::HTTPError" do | ||
expect { subject.request(uri, options) }.to raise_error(Bundler::HTTPError, | ||
"Network error while fetching http://www.uri-to-fetch.com/api/v2/endpoint") | ||
"Network error while fetching http://www.uri-to-fetch.com/api/v2/endpoint (other error about network)") | ||
end | ||
|
||
context "when the there are credentials provided in the request" do | ||
|
@@ -233,7 +233,7 @@ | |
|
||
it "should raise a Bundler::HTTPError that doesn't contain the password" do | ||
expect { subject.request(uri, options) }.to raise_error(Bundler::HTTPError, | ||
"Network error while fetching http://[email protected]/api/v2/endpoint") | ||
"Network error while fetching http://[email protected]/api/v2/endpoint (other error about network)") | ||
end | ||
end | ||
end | ||
|
@@ -243,7 +243,7 @@ | |
|
||
it "should raise a Bundler::Fetcher::HTTPError" do | ||
expect { subject.request(uri, options) }.to raise_error(Bundler::HTTPError, | ||
"Network error while fetching http://www.uri-to-fetch.com/api/v2/endpoint") | ||
"Network error while fetching http://www.uri-to-fetch.com/api/v2/endpoint (#{message})") | ||
end | ||
end | ||
end | ||
|