Resolves #4889: Add by default storage filter #4930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@pepetorres1998: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4889
Description
Add a filter for the default storage location of the requests' partners. I've followed the conventions I found in the code. I thought it would be better to have that consistency.
Type of change
How Has This Been Tested?
"Log in as [email protected]
Password: password!
Click Requests in the left-hand menu
To manually test this properly, you will need to make sure that at least some of the partners have default storage locations. To add that, go to Partner Agencies | All Partners click on a partner, then Edit Partner Information. Choose a Default Storage Location, then Update Partner."
Screenshots