Fix the transfer line item quantity can be negative. #4908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
requested changes
Jan 2, 2025
| ] | ||
| ) | ||
| post :create, params: { transfer: attributes } | ||
| expect(flash.keys).to match_array(['error']) |
There was a problem hiding this comment.
This is more of a model test than a controller test. Should be moved to the model specs.
nozomirin
force-pushed
the
4487-fix-line-item-quantity-can-be-negative
branch
from
7fa75cd to
69f7e0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4487
Description
Only transfers are able to save negative value.
Type of change
How Has This Been Tested?
bundle exec rspec spec/controllers/transfers_controller_spec.rb:64Screenshots