[hotfix] Add scrolling to confirmation modals for many items display #4587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cielf
approved these changes
Aug 10, 2024
|
@danielabar: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix/follow-on to #3052
Description
Follow-on from Slack discussion with myself and @cielf: For partner request confirmation modal, if there are many items in the request and user is on a small-ish screen, then it only shows the middle portion of the table in the modal, and they can't see all the content and interact with it such as clicking Yes/No buttons.
Type of change
Hotfix: Added scrolling to the modal body for partner confirmation modal. While I was at it, noticed the distribution confirmation modal introduced back in #3090 had the same issue so I fixed that as well.
How Has This Been Tested?
To try this out, follow the same steps as desribed in #4553 and #4367, but add a lot of items, at least 9 or 10. And then size down your browser window. When the confirmation modal appears, you should be able to scroll through the contents and interact with the Yes/No buttons.
Screenshots
I'm on a Mac so the scrollbars only appear when scrolling, it might look different on Windows.
Partner Request
Distribution