Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Add category drop-down menu #450

Merged
merged 1 commit into from
Aug 2, 2018
Merged

Conversation

chiefkikio
Copy link
Collaborator

Resolves #345

Description

This uses html5 datalists. The input field will act like a select box if clicked on and empty. It will act as auto complete when a user starts typing text.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I have created new items, update items, and deleted items. I also ran the rspec tests.

Screenshots

@chiefkikio chiefkikio force-pushed the 345-category-drop-down branch from 83d3d27 to 54ba8cb Compare July 16, 2018 16:50
<%= f.input_field :category, class: "form-control" %>
<%= f.input_field :category, class: "form-control", list:"category" %>
<datalist id="category">
<%- Item.all.map(&:category).uniq.each do |category| %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be CanonicalItem not Item.

Sorry reviews are moving slow, there is generally a bit of a dip in activity after the event and I know the team team leads for this project have a lot of real life stuff going on right now... In fact, one of them just got married! :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though this is for the item views? (new/update)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. All items are a type of canonical item. Let me take a closer look :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore my previous comments. :)

@seanmarcia seanmarcia merged commit 12887f1 into master Aug 2, 2018
@seanmarcia seanmarcia deleted the 345-category-drop-down branch September 15, 2018 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Category Drop-Down Menu (Creating NEW Inventory Items)
2 participants