-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4397 - Add Request units to item new/edit #4418
4397 - Add Request units to item new/edit #4418
Conversation
This reverts commit 1d980f5.
Passes initial light testing, fwiw. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes!
fix: wrap creation in flipper Co-authored-by: Brock Wilcox <[email protected]>
fix: conditionally render column Co-authored-by: Brock Wilcox <[email protected]>
…m/sean-dickinson/human-essentials into 4397-add-reporting-units-to-items
@sean-dickinson real fail over in the system specs (log) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Nice and safe behind the Flipper and looks good!
Resolves #4397
Description
ItemUnit
model less useful. If we need to keep units around that the organization has deleted or changed, we may need to reconsider this approach as I'm currently relying on the unit id's and just copying over the name based on the ids that are selected from the form.accepts_nested_attributes
for, but given the "syncing" that I needed to do I decided to use a more explicit path initially.Type of change
How Has This Been Tested?
:enable_packs
Screenshots