AdminsController currently handles CRUD for Organization model which is a mismatch of resource, this should be refactored

[armahillo]

/app/controllers/admins_controller.rb has CRUD actions for maintaining Organization records.

Instead, we should create an admin namespace, set up authorization there (the User model already has is_super_admin?) and then create an organizations_controller.rb within it that performs these actions. We can also set up Admin CRUD for Canonicaltem, Users, and BarcodeItem.

• Create Admin namespace
• Create Admin::OrganizationsController
• Create Admin::CanonicalItemsController
• Create Admin::UsersController
• Create Admin::BarcodeItemsController
• Remove previous administrative functions for those models from other places they may have been
• Write new specs to cover these new controllers
• Write new views for these new controllers
• Fix any broken specs

User Interface for BarcodeAdmin

• Default view for Admin::BarcodeItems#index is global only (we will likely need to add will_paginate)
• Filter on canonical item
• Filter on "global?"
• Filter on barcode value
• Filter on organization
• Add New Barcode for adding new Global barcodes (mapping to canonical items only)
• Create a new action / view that creates a report of commonly used barcode values across multiple organizations

[IlinDmitry]

Hello @armahillo! I read about Active Admin.
Maybe it's fit to this task?

[armahillo]

@IlinDmitry Hello!
Funny you should mention that... That was actually what we used for the very first iteration of this project, --two-- three years ago!

I think AA would add more complexity than we need; but if you want to do this and keep it simple, basic rails scaffolds would probably be fine for the Controller/Views, so long as authorization is added. :)

[IlinDmitry]

@armahillo, hi.
I see that CanonicalItem is only in your branch 314-item-refactor.
Should i use it, or better wait untill you'll merge into master?

[armahillo]

Oh definitely wait until that gets merged in before using it. It's a pretty big refactor

…

On Mon, May 14, 2018, 10:12 AM Dmitry ***@***.***> wrote: @armahillo <https://github.com/armahillo>, hi. I see that CanonicalItem is only in your branch 314-item-refactor. Should i use it, or better wait untill you'll merge into master? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#326 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAeqW-SHBnmFcrEDtJsJCXei4fOoDqYYks5tyZDUgaJpZM4T6w6r> .

[armahillo]

@IlinDmitry OK #314 has been merged into master - if you're still interested in working on this one, it's ready to be worked on. :)

[IlinDmitry]

@armahillo, hi!
Now user with regular rights can create/edit/delete barcodes.
With the new functionality user with regular rights would only view them?
Only user with superadmin rights would create/edit/delete barcodes?
Or maybe user with regular rights would also create new barcodes when creating new donations?

User with superadmin rights can edit/delete only for models, that belongs to his organization or for all organizations?

[armahillo]

@IlinDmitry You're definitely going in the right direction.

Non-Admins should still be able to edit/update their own organization, and users should be able to update their own records (I saw that both Organizations and Users had been moved into the Admin namespace, which is fine, but the Admin namespace actions should be more global, and the non-Admin ones should be scoped down to only what the user needs to be able to see).

Re: Barcodes
Users can still create barcodes, but the barcodes will associate with Item. The global barcodes are associated with CanonicalItem. That's the main difference. The global ones would be in the admin namespace, non-global ones can still be in the regular namespace.

SuperAdmins should be able to do CRUD actions on the models I mention in the original post.

Does this make sense?

[armahillo]

@IlinDmitry Hello! Have you been able to work on this at all? If not, push up any latest changes and one of us can take it over, IIRC you've got exciting family stuff happening right now :) Let me know!