Bug: clear contact types in update #6118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejonroberts
requested review from
compwron,
FireLemons and
elasticspoon
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #6117
What changed, and why?
See Issue and/or bugsnag, which I cannot access.
Used the existing
CaseContact#update_cleaning_contact_typesmethod to clear contact types before update (within a transaction). I am just guessing that this is why that method exists, to prevent the CaseContactContactTypevalidates :case_contact_id, uniqueness: {scope: :contact_type_idfrom causing this issue. There is probably a 'better' way to handle these, but without more info about the data or how to reproduce, I just wanted to try something quick.How is this tested? (please write tests!) 💖💪
I could not reproduce the issue in the new/edit system specs. I don't know exactly what is happening with the production data. So this is current specs only.