Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: swap db:reset to db:setup #5988

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix: swap db:reset to db:setup #5988

merged 1 commit into from
Aug 21, 2024

Conversation

elasticspoon
Copy link
Collaborator

@elasticspoon elasticspoon commented Aug 14, 2024 •
edited
Loading

DB setup includes seeding of database which we don't need to do in your github actions tests.

@elasticspoon
fix: swap db:reset to db:setup
91ef211 
DB setup includes seeding of database which we don't need to do in your
github actions tests.
@elasticspoon elasticspoon marked this pull request as ready for review August 14, 2024 01:21
@elasticspoon elasticspoon merged commit b391581 into main Aug 21, 2024
19 checks passed
@elasticspoon elasticspoon deleted the fix/remove-db-reset-in-docker-yml branch August 21, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejonroberts thejonroberts thejonroberts approved these changes

@compwron compwron Awaiting requested review from compwron compwron is a code owner

@FireLemons FireLemons Awaiting requested review from FireLemons FireLemons is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elasticspoon @thejonroberts