fix n+1 queries issue in supervisors#index and supervisors#datatable #5947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_controller#datatable
guswhitten
requested review from
compwron,
FireLemons and
elasticspoon
as code owners
elasticspoon
reviewed
Aug 1, 2024
| @@ -12,7 +12,10 @@ class SupervisorsController < ApplicationController | |||
|
|
|||
| def index | |||
| authorize Supervisor | |||
| @supervisors = policy_scope(current_organization.supervisors) | |||
| @supervisors = policy_scope(current_organization.supervisors).includes( | |||
There was a problem hiding this comment.
Do you know what this policy scope is adding to the query? could we move the includes? or is it reused elsewhere where the preloading isn't needed?
There was a problem hiding this comment.
i'm not sure about the policy_scope. i did not see other uses of @supervisors atm. is there a place you think itd be better to move it to?
There was a problem hiding this comment.
I'm not making a suggestion I was just posing another angle that you might consider, since it might be less code duplication.
You could move the includes bits to https://github.com/rubyforgood/casa/blob/main/app/policies/supervisor_policy.rb and have something like
in there.…ml.erb formatting fixes
elasticspoon
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #5890
Resolve #5891
What changed, and why?
Fixes the N+1 issues for the Supervisors#index and Supervisors#datatable. Does this by preloading any record associations that are used later on.
How is this tested? (please write tests!) 💖💪
Screenshots please :)
supervisors#indexbeforesupervisors#indexaftersupervisors#datatablebeforesupervisors#datatableafter