Fix N+1 issues in form_controller#show #5945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tifications factorybots
guswhitten
requested review from
compwron,
FireLemons and
elasticspoon
as code owners
github-actions
bot
added
dependencies
compwron
reviewed
Jul 26, 2024
| @@ -49,18 +49,21 @@ def update | |||
| private | |||
|
|
|||
| def set_case_contact | |||
| @case_contact = CaseContact.find(params[:case_contact_id]) | |||
There was a problem hiding this comment.
(not this PR) someday we should add some palicy_scope to this 😓
|
We could add more tests for number of db queries using a library someday, but we don't have it yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #5893
What changed, and why?
Fixes the N+1 issues for the FormController#show that "bullet" complained about. Does this by preloading any record associations that are used later on.
How is this tested? (please write tests!) 💖💪
Screenshots please :)
Before:
After:
Feelings gif (optional)