5906 update renders for turbo #5930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
mononoken
requested review from
compwron,
FireLemons,
littleforest and
elasticspoon
as code owners
Add 422 status to all form failure statuses that had no status specified
mononoken
force-pushed
the
5906_update_renders_for_turbo
branch
from
23b9c20 to
cfed33c
Compare
elasticspoon
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
This does not resolve #5906, but is the first part in completing it.
What changed, and why?
Turbo expects all form failures to return 422 (unprocessable entity). This used to not be required in Rails, so many renders from form failures just returned 200 by default. This PR adds 422 to all render messages in controllers for form failures.
Beyond the Turbo requirement, this is a better practice and should not break any old behavior.
How is this tested? (please write tests!) 💖💪
I update tests that are affected by the changed message. Many tests were asserting for
were_successfulor similar but now they properly expect 422.Screenshots please :)
Note the response in the network tab:
