fix: parallel timeout improvements #5859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticspoon
force-pushed
the
fix/improve-test-timeouts
branch
2 times, most recently
from
ebc72a5 to
4e1f0bf
Compare
elasticspoon
force-pushed
the
fix/improve-test-timeouts
branch
3 times, most recently
from
15a5370 to
4f873d9
Compare
compwron
approved these changes
Jul 5, 2024
elasticspoon
force-pushed
the
fix/improve-test-timeouts
branch
2 times, most recently
from
92bedd3 to
fecd0c7
Compare
elasticspoon
force-pushed
the
fix/improve-test-timeouts
branch
from
312106a to
1c82371
Compare
add per test timeout based on ENV variable - we have lots of issues with tests hanging but us being unsure which test hung. This will allow us to set a max time for test and get feedback on which ones are timing out. fail fast docker ci - docker is used mainly as a verification step. It should only give info about docker itself working or not. Might as well make it fail fast. fix: change queue_adapter - lots of failures seem to stem from background jobs, fixing the queue_adapter is a suggested step
elasticspoon
force-pushed
the
fix/improve-test-timeouts
branch
from
3364aae to
9dd27ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created an ENV variable
TEST_MAX_DURATION. If set the max time each test can take will equal that max duration in seconds. If it takes longer the test will fail with an error.Additionally docker will not fail fast in CI. That test suite is intended to be supplemental. If it is failing, we gain no additional insight compared to the regular RSpec suite.