Moved impersonate message to top of the page, put it in a red box #5802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freestylebit
requested review from
compwron,
FireLemons,
littleforest and
elasticspoon
as code owners
freestylebit
force-pushed
the
pc-impersonate
branch
2 times, most recently
from
7ac2da3 to
609d264
Compare
|
rspec ./spec/views/layouts/sidebar.html.erb_spec.rb:153 # layout/sidebar impersonation renders a stop impersonating link when impersonating is failing since the message was moved out of the sidebar other stuff is unrelated as you figured out |
Ahh yes, I missed a spot. This should no longer be here since the stuff has been moved. |
|
I think this just needs a rebased on main now. |
freestylebit
force-pushed
the
pc-impersonate
branch
from
6482c7e to
12390a3
Compare
elasticspoon
requested changes
Jun 3, 2024
freestylebit
force-pushed
the
pc-impersonate
branch
from
ce503e4 to
1f5d84c
Compare
freestylebit
force-pushed
the
pc-impersonate
branch
from
1f5d84c to
736f7a7
Compare
elasticspoon
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #5758
What changed, and why?
Moved the impersonate banner from the sidebar to the top of the page
Put it inside a red box, make it more prominent.
How is this tested? (please write tests!) 💖💪
Note: if you see a flake in your test build in github actions, please post in slack #casa "Flaky test: " :) 💪
Note: We love capybara tests! If you are writing both haml/js and ruby, please try to test your work with tests at every level including system tests like https://github.com/rubyforgood/casa/tree/main/spec/system
Screenshots please :)
Run your local server and take a screenshot of your work! Try to include the URL of the page as well as the contents of the page.
Feelings gif (optional)
What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
