Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Manage Volunteers' Styling on /volunteers page rubyforgood#5761 #5791

Merged
merged 2 commits into from
Jun 1, 2024

Conversation

Ivarkentje
Copy link
Contributor

@Ivarkentje Ivarkentje commented May 29, 2024

What github issue is this PR for, if any?

Resolves #5761

What changed, and why?

The button no longer moves the page down by becoming invisible instead of being removed. Additionally, the checkboxes now have a darker background color for better contrast.

How is this tested? (please write tests!) 💖💪

Note: if you see a flake in your test build in github actions, please post in slack #casa "Flaky test: " :) 💪
Note: We love capybara tests! If you are writing both haml/js and ruby, please try to test your work with tests at every level including system tests like https://github.com/rubyforgood/casa/tree/main/spec/system

No changes in tests since it's UI only.

Screenshots please :)

Run your local server and take a screenshot of your work! Try to include the URL of the page as well as the contents of the page.
image
image

Feelings gif (optional)

What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:

![alt text](https://media.giphy.com/media/1nP7ThJFes5pgXKUNf/giphy.gif)

@github-actions github-actions bot added dependencies Pull requests that update a dependency file erb labels May 29, 2024
@elasticspoon
Copy link
Collaborator

I did a poor job explaining. Can you make the border of the checkboxes higher contrast but leave the background unchanged

Copy link
Collaborator

@elasticspoon elasticspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you ❤️

@elasticspoon elasticspoon merged commit 7170208 into rubyforgood:main Jun 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file erb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "Manage Volunteers" Styling on /volunteers page
2 participants