refactor: twilio validation #5743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove additional Twilio error logging Moves twilio stubbing to rails helper to reduce duplication Changes twilio validation: twilio credentials do not need validation if an organization does not have twilio enabled
elasticspoon
force-pushed
the
change-twilio-validations
branch
from
760a6c7 to
3218d59
Compare
elasticspoon
requested review from
compwron,
FireLemons and
littleforest
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5742 added logging. This removes that logging and changes some validation behavior. The actual fixes to the data will probably need to be done manually in the prod console.
My current theory is that there is just bad data in some organization but the updates have never happened in
after_partyso a deploy has never failed to the issues.